Add support for ServiceStack.Redis 8.0.0 #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
area:tracer
bouwkast
approved these changes
Nov 22, 2023
Datadog ReportBranch report: ✅ |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4911) - mean (71ms) : 62, 80
. : milestone, 71,
master - mean (70ms) : 62, 78
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (4911) - mean (997ms) : 975, 1018
. : milestone, 997,
master - mean (998ms) : 982, 1013
. : milestone, 998,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4911) - mean (105ms) : 101, 109
. : milestone, 105,
master - mean (106ms) : 103, 109
. : milestone, 106,
section CallTarget+Inlining+NGEN
This PR (4911) - mean (687ms) : 671, 703
. : milestone, 687,
master - mean (686ms) : 667, 705
. : milestone, 686,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4911) - mean (90ms) : 86, 94
. : milestone, 90,
master - mean (90ms) : 87, 92
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (4911) - mean (660ms) : 630, 690
. : milestone, 660,
master - mean (661ms) : 634, 687
. : milestone, 661,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4911) - mean (188ms) : 184, 192
. : milestone, 188,
master - mean (188ms) : 186, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (4911) - mean (1,133ms) : 1110, 1155
. : milestone, 1133,
master - mean (1,136ms) : 1115, 1157
. : milestone, 1136,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4911) - mean (272ms) : 267, 277
. : milestone, 272,
master - mean (272ms) : 268, 276
. : milestone, 272,
section CallTarget+Inlining+NGEN
This PR (4911) - mean (1,092ms) : 1070, 1114
. : milestone, 1092,
master - mean (1,092ms) : 1066, 1118
. : milestone, 1092,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4911) - mean (261ms) : 257, 266
. : milestone, 261,
master - mean (261ms) : 257, 265
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (4911) - mean (1,056ms) : 1032, 1080
. : milestone, 1056,
master - mean (1,059ms) : 1036, 1081
. : milestone, 1059,
|
pierotibou
approved these changes
Nov 22, 2023
| @@ -54,7 +54,7 @@ public class PackageVersions | |||
|
|
|||
| public static IEnumerable<object[]> RabbitMQ => IsAllMinorPackageVersions ? PackageVersionsLatestMinors.RabbitMQ : PackageVersionsLatestSpecific.RabbitMQ; | |||
|
|
|||
| public static IEnumerable<object[]> DataStreamsRabbitMQ => IsAllMinorPackageVersions ? PackageVersionsLatestMinors. DataStreamsRabbitMQ : PackageVersionsLatestSpecific. DataStreamsRabbitMQ; | |||
There was a problem hiding this comment.
Wait, how did that work with a space? :wow: :til: I didn't know it was supported
There was a problem hiding this comment.
It was just lucky that it's not used anywhere important 😅
andrewlock
force-pushed
the
andrew/add-support-for-servicestack
branch
from
3dc5f96
to
39712d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds support for ServiceStack.Redis 8.0.0
Reason for change
They released a new version recently
Implementation details
Bump the assembly versions and 🤞
Test coverage
This should cover it